TINY-11909: Add support for readonly mode#77
Conversation
|
(question) Will the editor be in readonly mode? I think it won't. Because initially editor's init method has but the We can't use the |
don't we would have the same behavior using the version check? if the |
Yes it would. Therefore we should set the init object correctly |
isn't the same? I mean if someone with |
| return prefix + '_' + Math.floor(Math.random() * 1000000000) + String(Date.now()); | ||
| }; | ||
|
|
||
| const isDisabledOptionSupported = (editor: TinyMCEEditor): boolean => { |
There was a problem hiding this comment.
I think this check needs to be different after talking to @michalnieruchalski-tiugo since we want to feed readonly or disabled in at init time as well and then we don't have the editor instance.
There was a problem hiding this comment.
If they use disabled=true on a old editor version then it wouldn't be disabled since that option didn't exist prior to 7.6.
There was a problem hiding this comment.
@spocke, @michalnieruchalski-tiugo I fixed it, with a check in the setup, let me know what do you think about it
tiny-ben-tran
left a comment
There was a problem hiding this comment.
Bumping the minor version should fix the CI failure
Related ticket: TINY-11909
added support for readonly mode and now disabled prop uses the editor disable